Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move XMLHttpRequest/ to xhr/ #8937

Merged
merged 4 commits into from
Jan 6, 2018
Merged

Move XMLHttpRequest/ to xhr/ #8937

merged 4 commits into from
Jan 6, 2018

Conversation

foolip
Copy link
Member

@foolip foolip commented Jan 5, 2018

Like #8895 for quirks,
this adapts to whatwg/xhr#184, after which the
wpt links are generated and match the shortname.
https://xhr.spec.whatwg.org/ currently has a 404 link to
https://github.com/w3c/web-platform-tests/tree/master/xhr.

Steps taken:

  • rename the directory
  • sed 's#/XMLHttpRequest#/xhr#g' everywhere
  • manually handle a few remaining cases of "XMLHttpRequest/"
  • look at ouput of grep -E '\SXMLHttpRequest' and 'XMLHttpRequest[^(;]'

This change is Reviewable

@foolip
Copy link
Member Author

foolip commented Jan 5, 2018

Split into a few commits for ease of review, please squash as a single commit using the description of the PR. (The sed step is split more than described, but just for ease of review.)

foolip added a commit to foolip/day-to-day that referenced this pull request Jan 5, 2018
@w3c-bots
Copy link

w3c-bots commented Jan 6, 2018

Build ERRORED

Started: 2018-01-06 10:48:19
Finished: 2018-01-06 11:37:39

Failing Jobs

  • firefox:nightly
  • chrome:dev
  • MicrosoftEdge:14.14393

View more information about this build on:

@annevk
Copy link
Member

annevk commented Jan 6, 2018

@jgraham it seems you might need to land this because of the Firefox bot timing out.

@foolip
Copy link
Member Author

foolip commented Jan 6, 2018

Jobs for the other browsers are also failing, but those failures aren't blocking. Root cause is #7660.

I'll merge.

@foolip foolip merged commit 2cb86af into master Jan 6, 2018
@foolip foolip deleted the rename-xhr branch January 6, 2018 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants